feat: support response streaming on node env#433
Merged
sanketsudake merged 1 commit intofission:masterfrom Sep 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds response streaming support to the Node.js environment by allowing fission functions to return a Readable stream as the response body, which is then piped directly to the HTTP response.
- Imports the Readable class from node:stream module
- Adds conditional logic to handle Readable streams by piping them to the response instead of sending them directly
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
66b739c to
a63ea1f
Compare
Contributor
Author
|
Hi @sanketsudake, I just fixed the style issues mentioned by copilot. |
sanketsudake
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR the node environment now supports response streaming by returning a Readable as the body from the fission function.
This environment can be tried with: