ppl pp #7590
ppl pp #7590
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wu-hui
force-pushed
the
feat/pipeline/public-preview
branch
from
0283543 to
3f07dab
Compare
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
google-cla
bot
added
cla: no
cla: yes
wu-hui
force-pushed
the
feat/pipeline/public-preview
branch
from
3f39257 to
106b64e
Compare
wu-hui
force-pushed
the
feat/pipeline/public-preview
branch
from
106b64e to
6f1525f
Compare
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
First set of files, up to firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/FunctionRegistry.kt.
Nothing major other than making sure realtime pipelines stay private for launch
|
|
||
| # 26.1.0 | ||
|
|
||
| - [feature] Release Firestore Pipelines for Enterprise edition. |
There was a problem hiding this comment.
Do we want to mention the feature is in preview? This differentiates from a future release where we remove any flags on the API when we make it GA?
| * com.google.firebase.firestore.conformance}) were modified to support the Android SDK. | ||
| */ | ||
| @RunWith(Parameterized.class) | ||
| @Ignore |
There was a problem hiding this comment.
Is this @Ignore intentional? If so, should we add a comment or TODO to re-activate?
| * @return {@code RealtimePipelineSource} for this Firestore instance. | ||
| */ | ||
| @NonNull | ||
| RealtimePipelineSource realtimePipeline() { |
There was a problem hiding this comment.
This should be hidden in the initial public release?
| * A `Snapshot` contains the results of a pipeline execution. It can be iterated to retrieve the | ||
| * individual `PipelineResult` objects. | ||
| */ | ||
| class Snapshot internal constructor(executionTime: Timestamp, results: List<PipelineResult>) : |
There was a problem hiding this comment.
Is there any reason we make Pipeline.Snapshot a nested class, but QuerySnapshot is not. I don't recall if this was part of the Pipelines API proposal. If so, then dismiss this comment
| * @param field The first [String] name of field to remove. | ||
| * @param additionalFields Optional additional [String] name of fields to remove. | ||
| * @return A new [Pipeline] object with this stage appended to the stage list. | ||
| */ |
There was a problem hiding this comment.
Across the entire pipelines API, should we use some sort of attribute to mark the API as "beta"? Or should we add that to the description in each javadoc comment?
| * The `__name__` field will not be returned if the query projects away this field. For example: | ||
| * ``` | ||
| * // this query does not select the `__name__` field as part of the select stage, | ||
| * // so the __name__ field will not be in the output docs from this stage |
There was a problem hiding this comment.
Need to verify if this is still true.
| @@ -0,0 +1,693 @@ | |||
| // Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
skipping this file on initial review
| } | ||
|
|
||
| @NonNull | ||
| public RealtimePipeline toRealtimePipeline( |
There was a problem hiding this comment.
Hide in current release?
| } | ||
|
|
||
| // Many Pipelines require first parameter to be separated out from rest. | ||
| private static <T> T[] skipFirstToArray(List<T> list, IntFunction<T[]> generator) { |
There was a problem hiding this comment.
extra nit, this could call the function below with noop map function
|
|
||
| private final Query query; | ||
| /** A pair of documents that represent the edges of a limit query. */ | ||
| // TODO(pipeline): This is a direct port from C++. Ideally this should be a sumtype with variances |
There was a problem hiding this comment.
Calling out this TODO in case it is something you intended to fix in this release
5 participants
No description provided.