Skip to content

fix(firebase-frameworks): don't delete an in-flight app on concurrent #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoortizz merged 3 commits into from
Sep 23, 2026
Merged

fix(firebase-frameworks): don't delete an in-flight app on concurrent #689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fe00cb
fix(firebase-frameworks): don't delete an in-flight app on concurrent
leoortizz Sep 14, 2026
03a2e40
Merge branch 'main' into fix/frameworks-auth-lru-race
leoortizz Sep 23, 2026
ab66de2
Merge branch 'main' into fix/frameworks-auth-lru-race
leoortizz Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/firebase-frameworks/src/firebase-aware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const adminAuth = getAdminAuth(adminApp);
const firebaseAppsLRU = new LRU<string, FirebaseApp>({
max: LRU_MAX_INSTANCES,
ttl: LRU_TTL,
allowStale: true,
updateAgeOnGet: true,
dispose: (value) => {
deleteApp(value);
Expand Down Expand Up @@ -64,6 +63,10 @@ const handleAuth = async (req: Request, res: Response) => {
.verifySessionCookie(__session, true)
.catch((e: Error) => console.error(e.message)));
if (isRevoked) return;
// A concurrent request may have initialized the app while we awaited
app = firebaseAppsLRU.get(uid);
Comment thread
leoortizz marked this conversation as resolved.
}
if (!app) {
const random = Math.random().toString(36).split(".")[1];
const appName = `authenticated-context:${uid}:${random}`;
// Force JS SDK autoinit with the undefined
Expand All @@ -90,7 +93,8 @@ export const handleFactory =
if (req.url === "/__session") {
await mintCookie(req, res);
} else {
await handleAuth(req, res);
// Auth failure = unauthenticated request
await handleAuth(req, res).catch((e: Error) => console.error(e.message));
frameworkHandle(req, res);
}
};
Loading