Repository navigation
hermes image: a connection's skill is shown to an agent that holds the connection (FIN-509) - #1296
Draft
alexlwn123 wants to merge 1 commit into
Draft
alexlwn123 wants to merge 1 commit into
alexlwn123 wants to merge 1 commit into
Conversation
…e connection (FIN-509) Each managed skill that names a connection (metadata: fragment: connection) is disabled, by name (Hermes' skills.disabled), in the profile of an agent whose credentials hold no such provider, and shown once they do. So an agent's prompt lists the skills of what its owner connected, however many connections the platform offers: with a hundred, about 5,000 tokens a chat that no agent pays. Read again whenever a profile's config is (a connect, a disconnect, and on the models cadence), so it follows a new skill too. The image's, as the platform rule has it: no platform or wire change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Hermes lists every installed skill's name and description in an agent's prompt, and the image installs the whole managed set. With a skill per connection that grows with the catalog: at a hundred connections, about 5,000 tokens in every chat, connected or not.
Each managed skill that names a connection (
metadata: fragment: connection) is now disabled, by name, in the profile of an agent whose credentials hold no such provider (Hermes'skills.disabled), and shown once they do. It is read again whenever a profile's config is written: at a connect or disconnect, and on the models cadence, so it follows a newly released skill too.The image's, as the platform rule has it. No platform or wire change. 3 files, +90.
Gaps
skills.disabledis read from a local copy of Hermes' source (agent/skill_utils.py,get_disabled_skill_names), not confirmed on the pinnedv0.21.7image, nor that it covers skills fromexternal_dirs. The Docker and real-Hermes lanes are owed.What ran
On the stack's tip (
8f123596e, on mastere6478e699), on the Mac:cargo xtask check: source guards, 155 JavaScript files parse, 38 JavaScript test files pass, then it stops atfragment-cli --test mcp, which fails the same way on master on this machine (it writes a config folder macOS does not read).cargo test --workspace --all-features --no-fail-fast: 1,445 passed, 2 failed, both environmental here (fragment-cli --test mcp;fragment-e2e hosted::tests::the_plan_follows_what_each_section_needs, which needs Chrome).cargo clippy --workspace --all-targets --all-features -- -D warnings, the cell's Wasm clippy, andimages/clippy: clean.images/:cargo test -p hermes-boot, 89 passed.Not run, on purpose for now: any e2e lane, the Docker image tests, the Wasm size delta, and a Codex review. This is a draft until those are in. Nothing here was tried against a real provider or a real agent.
The stack (FIN-509)
fragment api· 4. the shared shape, with Google, Linear and Salesforce · 5. sign-in scopes · 6. six connections · 7. the skill filter · 8. GitHub. Each is based on the one before, so its diff is its own.