"Intro", "Speedup" and "Boss" notably quieter than other sounds

[pokemonpasta]

I've noticed the following:

• When playing on dedicated servers (granted this is mostly Redsun), these sounds are consistently quieter than all other theme sounds and minigame sounds.
• When testing on listen server early on (i.e. when I first added the theme system), I never noticed this issue, it seems to have slowly creeped in over time
• Nowadays when testing new themes, I consistently have this problem, except with the default theme which sometimes plays these sounds at proper volume and sometimes doesn't? I've not seen any rhyme or reason to it. Aside from that it's consistent across themes, so I don't think it's an issue with the audio files as they are in the repo.

I thought it might be to do with the filter types, but that would affect minigame sounds too. I would like to deal with this issue before resolving #4 and #81, as to not cause myself more work later. I've had one person mention this issue to me directly, as well as people mentioning it on Redsun, so I don't believe it's just my end.

EDIT: Reworded issue for clarity.

[pokemonpasta]

I've narrowed this down, seems I was right about the filters.

This is the snd_show 1 for the intro sound as it as atm. Note the left and right channel levels.

This is the same test on failure. These instead have a value of 255.

These two sounds play by different functions - intro via PlaySoundOnAllClients(), and failure via PlaySoundOnClient(). The only difference between these functions is the entity = player slot in PlaySoundOnClient(), and they use different filters. To me it's clear that RECIPIENT_FILTER_GLOBAL has a limit to how loud its levels can be. This is supported by minigame music also using the lower value:

which also uses the PlaySoundOnAllClients() function. I can't verify this since I believe this is engine code, but I can at least implement a workaround: Make Ware_PlayGameSound() always use PlaySoundOnClient()

As I expected, this gives the desired 255 in L/R, but I would rather see if there's any solution where we can still use RECIPIENT_FILTER_GLOBAL. I'll leave this issue open until the next release.

[pokemonpasta]

Bandaid fix seems to be working well, I'm happy to leave it as a permanent solution. Closing..