Skip to content

fix: make settings dropdown text readable across all themes - #35

Merged
zulfikar-ditya merged 1 commit into
fexend:mainfrom
zulfikar-ditya:main
Aug 15, 2026
Merged

fix: make settings dropdown text readable across all themes#35
zulfikar-ditya merged 1 commit into
fexend:mainfrom
zulfikar-ditya:main

Conversation

@zulfikar-ditya

Copy link
Copy Markdown
Member

Fixes #34

Root cause

dropdown.foreground was set to #7c86ff20 in all 6 theme variants — the accent color at 12% alpha, which renders option text effectively invisible. dropdown.background and dropdown.listBackground were translucent with the same value, so the settings rows behind the open option list bled through it (visible in the issue screenshot, where "Chat › Agent: Max Requests" shows through the popup).

Fix

Each variant now uses an opaque surface matching its existing editorWidget.background, with a high-contrast foreground:

Theme background / listBackground foreground contrast
Fexend Theme (+ Italic) #020617 #ffffff 20.2:1
Medium Purple (+ Italic) #1e1537 #ffffff 17.3:1
Soft Dark (+ Italic) #0f172a #e2e8f0 14.5:1

dropdown.border goes from #7c86ff20 to #7c86ff40 so the now-opaque popup keeps a visible edge against the editor.

Notes

  • Medium Purple and Soft Dark define no settings.dropdown* keys at all, so their settings dropdowns inherit dropdown.* directly — that's why the closed control was faint there too, while the two main variants already had settings.dropdownForeground: #ffffff. The dropdown.* fix covers them through inheritance; no duplicate keys added.
  • Swept every theme for other *.foreground values with alpha below 0x60. The only other hits are intentional (whitespace glyphs, dimmed line numbers, overview-ruler marks) — dropdown.foreground was the sole text-readability bug.
  • Bumped to 1.0.9 with a CHANGELOG entry, matching the convention from the 1.0.8 fix.

🤖 Generated with Claude Code

dropdown.foreground was #7c86ff20 - the accent color at 12% alpha, which
rendered option text effectively invisible in the Settings editor. The
dropdown background and list background were translucent as well, so the
settings rows behind the open option list bled through it.

All 6 variants now use an opaque surface matching their existing
editorWidget.background, with a high-contrast foreground:

- Fexend Theme (+ Italic):     #020617 bg / #ffffff fg  (20.2:1)
- Medium Purple (+ Italic):    #1e1537 bg / #ffffff fg  (17.3:1)
- Soft Dark (+ Italic):        #0f172a bg / #e2e8f0 fg  (14.5:1)

dropdown.border goes from #7c86ff20 to #7c86ff40 so the now-opaque popup
keeps a visible edge against the editor.

Medium Purple and Soft Dark define no settings.dropdown* keys, so they
pick these up through inheritance.

Fixes fexend#34

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@zulfikar-ditya
zulfikar-ditya merged commit 68a2689 into fexend:main Aug 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Drop down in settings texts

1 participant