fix: make settings dropdown text readable across all themes - #35
Merged
Conversation
dropdown.foreground was #7c86ff20 - the accent color at 12% alpha, which rendered option text effectively invisible in the Settings editor. The dropdown background and list background were translucent as well, so the settings rows behind the open option list bled through it. All 6 variants now use an opaque surface matching their existing editorWidget.background, with a high-contrast foreground: - Fexend Theme (+ Italic): #020617 bg / #ffffff fg (20.2:1) - Medium Purple (+ Italic): #1e1537 bg / #ffffff fg (17.3:1) - Soft Dark (+ Italic): #0f172a bg / #e2e8f0 fg (14.5:1) dropdown.border goes from #7c86ff20 to #7c86ff40 so the now-opaque popup keeps a visible edge against the editor. Medium Purple and Soft Dark define no settings.dropdown* keys, so they pick these up through inheritance. Fixes fexend#34 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Root cause
dropdown.foregroundwas set to#7c86ff20in all 6 theme variants — the accent color at 12% alpha, which renders option text effectively invisible.dropdown.backgroundanddropdown.listBackgroundwere translucent with the same value, so the settings rows behind the open option list bled through it (visible in the issue screenshot, where "Chat › Agent: Max Requests" shows through the popup).Fix
Each variant now uses an opaque surface matching its existing
editorWidget.background, with a high-contrast foreground:#020617#ffffff#1e1537#ffffff#0f172a#e2e8f0dropdown.bordergoes from#7c86ff20to#7c86ff40so the now-opaque popup keeps a visible edge against the editor.Notes
settings.dropdown*keys at all, so their settings dropdowns inheritdropdown.*directly — that's why the closed control was faint there too, while the two main variants already hadsettings.dropdownForeground: #ffffff. Thedropdown.*fix covers them through inheritance; no duplicate keys added.*.foregroundvalues with alpha below0x60. The only other hits are intentional (whitespace glyphs, dimmed line numbers, overview-ruler marks) —dropdown.foregroundwas the sole text-readability bug.🤖 Generated with Claude Code