chore(tokens): drop dead sidebar brand tokens, sync DESIGN.md active state - #13
Conversation
…state The purple sidebar indicator/ring was removed in f73cd15 but its tokens (--sidebar-primary/-primary-foreground/-ring, plus their --color-* Tailwind bindings, light + dark) stayed behind with zero component references. DESIGN.md still documented the deleted 2px indicator as the active-state spec — it now describes what the component actually does (sidebar-accent background + font-medium). The Switch half of #5 is already resolved elsewhere (checked state runs on --accent-blue-fill). Closes #5.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a46dc0d3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --sidebar-foreground: oklch(0.21 0.004 95); | ||
| --sidebar-primary: oklch(0.55 0.22 290); | ||
| --sidebar-primary-foreground: oklch(0.985 0 0); | ||
| --sidebar-accent: var(--overlay-hover); |
There was a problem hiding this comment.
After this removal, opening the showcase’s Foundations → Colors page still renders the Brand entry declared at showcase/lib/color-catalog.ts:109 for --sidebar-primary. Because the variable is now undefined, its bar has no background, its tooltip resolves to —, and clicking it copies a nonexistent token; the repository contract also still identifies this as a reserved token. Update the local catalog and contract in the same change, or retain the token.
AGENTS.md reference: AGENTS.md:L330-L335
Useful? React with 👍 / 👎.
Missed consumer: the showcase rendered a swatch for the deleted token.
…ev-wall catalog (#906) Follow-up to felinics/ui#13 (merged as `f95e998`), which deleted the dead `--sidebar-primary` / `--sidebar-ring` tokens and synced DESIGN.md. - `packages/ui` gitlink: `ad14119` → `f95e998` - dev-wall `token-catalog.ts`: removes the three deleted tokens from the Sidebar family listing (the only host-side reference) No component in the host referenced these tokens — verified by grep across `apps/web`, `apps/desktop`, and `packages/*`. ## Test plan - [x] `vue-tsc` green - [ ] CI
1 participant
Closes #5.
Verified on current
origin/main:DESIGN.md:75documents the deleted 2pxprimaryindicatorsidebar-accentbg +font-medium, matchingsidebarMenuButtonVariants)--sidebar-primary/--sidebar-ringtokens--color-sidebar-*Tailwind bindings (13 lines)--brand--accent-blue-fillHost-side fallout: Memoh's dev-wall
token-catalog.tslistssidebar-primary/sidebar-ring; those two catalog lines need to go when the shell repo bumps its gitlink to this.Verification
pnpm run type-check✅pnpm run build-only✅sidebar-primary/sidebar-ringreferences remain insrc/