Draft
Conversation
Pull Request Test Coverage Report for Build 1158889962
💛 - Coveralls |
Owner
Author
|
@thewilkybarkid I haven't made up my mind if I want to have this in the module or not. Curious if the parser providing this directly would be a value-add for you. My current plan is to provide a const startPos = parser.getPosition(parser.startIndex); |
|
Probably worth not adding it to start with at least (feels a little too specialist). An aside, but I think this has the same problem that posthtml/posthtml-parser#80 had to work around: needing to be able to backtrack (a bit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at implementing a position tracker that works for streams. This is something that's been asked for every once in a while, and it seems easy enough to add.
Parser