Skip to content

Fix rototron calendars for new jmap calendars #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfsage merged 2 commits into from
Aug 5, 2026
Merged

Fix rototron calendars for new jmap calendars #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03147af
Rototron: Log JMAP errors so we can figure out what's going on
wolfsage Aug 5, 2026
7757ebd
Synergy/Rototron: JMAP Calendars now need a 'version' field
wolfsage Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/Synergy/Reactor/Rototron.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,13 @@ sub _replan_range ($self, $from_dt, $to_dt) {
],
});

# This is terrible. It just crashes on failure, so we get a "something went
# wrong". But it's easy, and it's better than "We never look at $res so
# errors are unreported."
$res->assert_successful_set("CalendarEvent/set");
eval {
$res->assert_successful_set("CalendarEvent/set");
};

if ($@) {
$Logger->log(["Failed to CalendarEvent/set. Res: %s", $res->response_payload ]);
}

$self->rototron->_duty_cache->%* = (); # should build this into Rototron

Expand Down
1 change: 1 addition & 0 deletions lib/Synergy/Rototron.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ sub compute_rotor_update ($self, $from_dt, $to_dt) {
my $start = $day->ymd . "T00:00:00";

$want{ $rotor->keyword }{ $start } = {
version => '2.0',
prodId => "$PROGRAM_ID",
title => join(q{ - }, $rotor->description, $name),
start => $start,
Expand Down
Loading