Skip to content

docs: define archive skill transport policy - #9

Open
akiezun wants to merge 1 commit into
facebookresearch:mainfrom
akiezun:autoform/p00-skill-transport-policy
Open

akiezun wants to merge 1 commit into
facebookresearch:mainfrom
akiezun:autoform/p00-skill-transport-policy

Conversation

@akiezun

@akiezun akiezun commented Sep 1, 2026

Copy link
Copy Markdown

Summary

  • records the verified 51-skill archive inventory and clean-room reuse policy
  • assigns every skill one disposition, target layer, and replacement owner
  • defines dependency-aware PR boundaries for future transport work
  • adds tests binding the human plan to the machine-readable manifest

Scope

This is P00 from ARCHIVE_SKILL_TRANSPORT_PLAN.md. The 1,203-line diff exceeds the normal warning threshold because it contains the complete 51-row review, the downstream PR contract, and its machine manifest; it adds no runtime behavior or generated assets.

Non-goals

  • no archived skill implementation
  • no autonomous execution on main
  • no model/provider integration
  • no archive redistribution or verbatim reuse
  • no PR merges

Dependencies

None. Later P-series work depends on this policy.

Validation

  • make lint
  • make test: 542 passed, 1 skipped
  • make check-example
  • plugin validator: passed
  • git diff --check

Risk and migration

Documentation, policy data, and tests only. Existing plugin and CLI surfaces are unchanged.

Rollback

Revert commit ccf1302; no runtime or persisted project data is affected.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 1, 2026
@akiezun
akiezun marked this pull request as ready for review September 1, 2026 02:39
@akiezun
akiezun marked this pull request as draft September 1, 2026 12:38
@akiezun
akiezun marked this pull request as ready for review September 1, 2026 13:00

@Deicyde Deicyde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: changes needed.

  • FORMALIZATION_QUALITY_GOAL.md:109-123 has fail-open eligibility paths. A statement: formalized leaf without declaration, and a mathlib: true leaf without statement/proof flags, can avoid the required quality evidence.
  • not-applicable has no default-deny applicability matrix; omitting origin can make source fidelity disappear.
  • The delivery DAG is not deterministic: C00's stated prerequisites conflict with the Phase 4 barrier, and E01 depends on “relevant merged core changes.”
  • The manifest tests do not enforce owners, dependency ordering, or rejection of unmanifested transported skills.
  • The mandatory plugin-validation command contains an unresolved host-local placeholder.

Please tighten the policy and tests before treating this document as an executable roadmap. Also state how P01-P03 relate to the newer skeleton/read-back work in #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants