Conversation
This was referenced Sep 18, 2026
Deicyde
commented
Sep 19, 2026
Deicyde
left a comment
Contributor
Author
There was a problem hiding this comment.
Review result: changes needed.
project/inspect.py:494-503probes lowercaseblueprintwithout requiring exact directory-entry spelling. On default macOS filesystems, formal-math's trackedBlueprint/Lean library is falsely reported as an Autoform vault; Linux reports differently.project/inspect.py:257-266rejects projects containing both Lake configuration formats, although Lake 4.32.2 validly selectslakefile.lean. Treat the unused file as an advisory diagnostic or document the stricter policy.project/inspect.py:819-825permits C1 controls such as U+009B and prints them raw in human output. Apply the catalog's Unicode control/surrogate rejection consistently.
All three cases were reproduced; the focused inspection suite still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the reviewed split of #8. This PR is independent of #13.
What this adds
autoform project inspectfor bounded, read-only inspection of Lean, Lake, Mathlib, Git, and Autoform project metadata.autoform project versionsbacked by a packaged catalog containing the tested Lean 4.32.2 and Mathlib v4.32.2 pair.Scope-only package registry entries remain indeterminate because offline metadata cannot prove an exact Git source.
Validation
make lintmake test: 627 passed, 1 skippedmake check-example