Repository navigation
Evaluate the output file produced by otbench run - #128
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otbench runevaluates the unsuffixed output path even when generation writes a different filename for--enable_nothink,--temperature, or--num_gens. Non-default runs fail to find their output or may evaluate an existing older file.Share the existing generation filename transformation with the run CLI, preserving its model-slash normalization and suffix order. Adds an integration regression that runs the actual CLI and generation script, controls the dataset/model boundary, writes a real output file, and verifies evaluation selects that file. It covers all eight flag combinations against explicit expected filenames; seven fail on main, all eight pass after the change.
Validation: Python 3.9.6,
python3 -m unittest discover -s projects/otb/tests -v(1 test, 8 cases passed on this branch), syntax compilation passed. No model/provider calls, GPU run, full-suite run, or hosted CI result is claimed. Based independently on main6bcc4813bfb72ec1dcec7923e449c027a4d9194e.