Repository navigation
Weight OTB general and math splits independently - #126
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_metricsincludes math rows in the general mean, then averages that mean with the math mean again. This double-weights math and makes the intended macro average depend on relative split sizes. A fixture with general accuracy/score 1 and math 0 reports 0.25 instead of 0.5; token means are similarly skewed.Exclude math rows from the general masks for both overthinking and underthinking. The regression checks accuracy, score, token means, F1, and invariance when identical general rows are duplicated. It fails on main and passes with this change.
Validation: Python 3.9.6 and real pandas,
python3 -m unittest discover -s projects/otb/tests -v(1 regression passed on this branch). Model imports are isolated; no model/provider calls, GPU benchmarking, full-suite run, or hosted CI result is claimed. Based on main6bcc4813bfb72ec1dcec7923e449c027a4d9194e.