Add IRuntime interface #54923
Open
Add IRuntime interface #54923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: After reviewing the feasibility of adding new Runtime functionality, we realized the current state of `Runtime` makes it hard/inconvenient to add new basic functionality. It requires creating a new interface (e.g. `IRuntime2`) to declare the new APIs. Then, everywhere it is needed, both the original `Runtime` and `IRuntime2` needs to passed in to access both APIs. After discussion, we decided to introduce `IRuntime`, which will declare most of the `Runtime` functionalities. All "protected" APIs, which made sense before interfaces were introduced, will now be public. The protected static methods of `Runtime` will remain as is for the Friends to access. After we decided to cut "stable" (after incoming JSI improvements), new functionalities will be added in `IRuntime2` interface. `IRuntime2` will inherit `IRuntime` to make existing functionality easy to access. Differential Revision: D89093651
meta-cla
bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89093651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After reviewing the feasibility of adding new Runtime functionality, we
realized the current state of
Runtimemakes it hard/inconvenient toadd new basic functionality. It requires creating a new interface (e.g.
IRuntime2) to declare the new APIs. Then, everywhere it is needed,both the original
RuntimeandIRuntime2needs to passed in to accessboth APIs.
After discussion, we decided to introduce
IRuntime, which will declaremost of the
Runtimefunctionalities. All "protected" APIs, which madesense before interfaces were introduced, will now be public. The
protected static methods of
Runtimewill remain as is for the Friendsto access.
After we decided to cut "stable" (after incoming JSI improvements), new
functionalities will be added in
IRuntime2interface.IRuntime2willinherit
IRuntimeto make existing functionality easy to access.Differential Revision: D89093651