Skip to content

Fix compatibility with fmt 12.2.0#2661

Open
xiaozhuai wants to merge 2 commits into
facebook:mainfrom
xiaozhuai:main
Open

Fix compatibility with fmt 12.2.0#2661
xiaozhuai wants to merge 2 commits into
facebook:mainfrom
xiaozhuai:main

Conversation

@xiaozhuai

Copy link
Copy Markdown

Problem

fmtlib/fmt deprecated <fmt/core.h> in commit 0007426. Starting from fmt 12.2.0, using <fmt/core.h> causes compilation errors because the deprecated include is now opt-in only.

Fix

Replace all #include <fmt/core.h> with #include <fmt/format.h>, which is the standard header in fmt 12.2.0+.

@meta-cla

meta-cla Bot commented Jun 16, 2026

Copy link
Copy Markdown

Hi @xiaozhuai!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Jun 16, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@zhjwpku

zhjwpku commented Jun 17, 2026

Copy link
Copy Markdown

Since folly is now targeting c++20, why not just replace fmt with std::format?

@xiaozhuai

Copy link
Copy Markdown
Author

Since folly is now targeting c++20, why not just replace fmt with std::format?

That's another matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants