Skip to content

Conversation

@julienrbrt
Copy link
Member

Overview

Found while testing, a sync node would display this log line, which is confusing.
The info is as well available in the config, no need to display it.

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 22, 2026, 1:16 PM

@claude
Copy link
Contributor

claude bot commented Jan 22, 2026

Claude finished @julienrbrt's task in 2m 22s —— View job


Code Review Complete ✅

Review Summary

This PR removes redundant log messages that were confusingly displayed when running sync nodes with single sequencer mode. The changes are clean, consistent, and well-justified.


Positive Findings

Consistent Implementation: The same log removal is applied uniformly across all three app entry points (testapp, evm, grpc) in apps/*/cmd/run.go:138-141, :177-180, :139-142 respectively.

No Test Dependencies: No tests reference the removed log message "single sequencer initialized".

No Documentation Impact: No documentation references the removed log output.

Preserves Important Logging: The based sequencer initialization log remains intact (lines 138-141 in each file), which is appropriate since:

  • Based sequencer mode is more specialized and benefits from explicit initialization confirmation
  • It includes additional context (da_epoch) beyond just the namespace
  • The forced inclusion namespace is more critical for based sequencer operation

Clean Deletion: Pure deletion with no side effects - no broken references or dangling code.


Analysis & Discussion

Why This Change Makes Sense

  1. Redundancy: The forced_inclusion_namespace value is already available in the node configuration (defined in pkg/config/config.go:189) and can be inspected via config display/dumps.

  2. Confusion for Sync Nodes: As noted in the PR description, sync nodes would display this log even though forced inclusion is primarily relevant for sequencer/aggregator nodes. The log appeared in the single sequencer code path but didn't provide actionable information for non-aggregator nodes.

  3. Asymmetry is Justified: The PR maintains asymmetry between single and based sequencer logs:

    • Based sequencer (kept): Logs forced_inclusion_namespace + da_epoch because forced inclusion is core to its operation
    • Single sequencer (removed): Logging namespace here was less meaningful since single sequencers don't exclusively rely on forced inclusion mechanisms

Minor Observation: Logging Consistency

While reviewing the codebase, I noticed that the forced_inclusion_namespace appears in logs only during sequencer initialization. There's no additional runtime logging when the namespace is actually used. This might be worth considering for debugging forced inclusion behavior, but it's outside the scope of this PR.


Recommendations

Approve: This PR is ready to merge. The changes are:

  • Minimal and focused
  • Consistently applied
  • Well-justified by the PR description
  • Free of breaking changes or test failures

No action items or changes needed.


Review Checklist

  • Analyze PR changes and understand context
  • Review the three modified files
  • Verify consistency of changes
  • Check for similar patterns in codebase
  • Provide comprehensive review feedback

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines application logging by eliminating a specific log message that was identified as confusing for sync nodes. The information previously conveyed by this log was already accessible via configuration, rendering its explicit display unnecessary and potentially misleading. The change improves log clarity without impacting functionality.

Highlights

  • Log Redundancy: Removed a redundant and potentially confusing log message related to 'single sequencer initialized' and 'forced_inclusion_namespace' from sequencer initialization logic across multiple applications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a redundant log message for the single sequencer initialization across several applications. This is a good cleanup. I've added one suggestion to improve logging consistency for the based sequencer as well.

I am having trouble creating individual review comments. Click here to see my feedback.

apps/evm/cmd/run.go (198-200)

medium

Removing this log is a good idea, as forced_inclusion_namespace is always empty due to the feature not being live yet.

For consistency, you might want to remove the forced_inclusion_namespace field from the based sequencer log as well (lines 176-179), since it's affected by the same issue and will also log an empty value.

You could change this:

		logger.Info().
			Str("forced_inclusion_namespace", nodeConfig.DA.GetForcedInclusionNamespace()).
			Uint64("da_epoch", genesis.DAEpochForcedInclusion).
			Msg("based sequencer initialized")

to this:

		logger.Info().
			Uint64("da_epoch", genesis.DAEpochForcedInclusion).
			Msg("based sequencer initialized")

This suggestion also applies to the similar code in apps/grpc/cmd/run.go and apps/testapp/cmd/run.go.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.89%. Comparing base (5660535) to head (d22044e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
- Coverage   57.91%   57.89%   -0.02%     
==========================================
  Files         110      110              
  Lines       10526    10526              
==========================================
- Hits         6096     6094       -2     
- Misses       3780     3781       +1     
- Partials      650      651       +1     
Flag Coverage Δ
combined 57.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 340d5cf Jan 22, 2026
31 checks passed
@julienrbrt julienrbrt deleted the julien/nits branch January 22, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants