-
Notifications
You must be signed in to change notification settings - Fork 246
chore: remove redundant log #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Claude finished @julienrbrt's task in 2m 22s —— View job Code Review Complete ✅Review SummaryThis PR removes redundant log messages that were confusingly displayed when running sync nodes with single sequencer mode. The changes are clean, consistent, and well-justified. Positive Findings✅ Consistent Implementation: The same log removal is applied uniformly across all three app entry points (testapp, evm, grpc) in ✅ No Test Dependencies: No tests reference the removed log message "single sequencer initialized". ✅ No Documentation Impact: No documentation references the removed log output. ✅ Preserves Important Logging: The based sequencer initialization log remains intact (lines 138-141 in each file), which is appropriate since:
✅ Clean Deletion: Pure deletion with no side effects - no broken references or dangling code. Analysis & DiscussionWhy This Change Makes Sense
Minor Observation: Logging ConsistencyWhile reviewing the codebase, I noticed that the RecommendationsApprove: This PR is ready to merge. The changes are:
No action items or changes needed. Review Checklist
|
Summary of ChangesHello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines application logging by eliminating a specific log message that was identified as confusing for sync nodes. The information previously conveyed by this log was already accessible via configuration, rendering its explicit display unnecessary and potentially misleading. The change improves log clarity without impacting functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a redundant log message for the single sequencer initialization across several applications. This is a good cleanup. I've added one suggestion to improve logging consistency for the based sequencer as well.
I am having trouble creating individual review comments. Click here to see my feedback.
apps/evm/cmd/run.go (198-200)
Removing this log is a good idea, as forced_inclusion_namespace is always empty due to the feature not being live yet.
For consistency, you might want to remove the forced_inclusion_namespace field from the based sequencer log as well (lines 176-179), since it's affected by the same issue and will also log an empty value.
You could change this:
logger.Info().
Str("forced_inclusion_namespace", nodeConfig.DA.GetForcedInclusionNamespace()).
Uint64("da_epoch", genesis.DAEpochForcedInclusion).
Msg("based sequencer initialized")to this:
logger.Info().
Uint64("da_epoch", genesis.DAEpochForcedInclusion).
Msg("based sequencer initialized")This suggestion also applies to the similar code in apps/grpc/cmd/run.go and apps/testapp/cmd/run.go.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
- Coverage 57.91% 57.89% -0.02%
==========================================
Files 110 110
Lines 10526 10526
==========================================
- Hits 6096 6094 -2
- Misses 3780 3781 +1
- Partials 650 651 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
Found while testing, a sync node would display this log line, which is confusing.
The info is as well available in the config, no need to display it.