Hardening: extract operator prefixes from constraint values - #4
Open
irfan-evoila wants to merge 2 commits into
Open
irfan-evoila wants to merge 2 commits into
irfan-evoila wants to merge 2 commits into
Conversation
ricket-son
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the monolithic LabelProcessor (774 lines) into a clean linear pipeline with clear separation of concerns:
Parse -> Normalize -> Enhance -> Validate -> Serialize.
Each step is now handled by a focused class (LabelParser, LabelNormalizer, LabelEnhancer), resulting in a more robust and maintainable architecture for future changes
Constraint values can encode operators as prefixes (e.g. !~^kube-.*).
Previously, these were treated as raw values and wrapped with the default =~ operator,
producing incorrect expressions like k8s_namespace_name=
"!^kube-.*".Now LabelEnhancer extracts !
, =, and != prefixes from constraint values and uses them as the actual operator.