feat(skill): add read_skill tool for inline skill loading in plan mode#3515
Open
yhemeo613 wants to merge 1 commit into
Open
feat(skill): add read_skill tool for inline skill loading in plan mode#3515yhemeo613 wants to merge 1 commit into
yhemeo613 wants to merge 1 commit into
Conversation
Adds parseRewind helper and wires /rewind into Controller.Submit() so all
frontends (TUI, desktop, HTTP) can trigger checkpoint-based rollback.
Usage:
/rewind → rewind to latest checkpoint (both)
/rewind <turn> → rewind to specific turn (both)
/rewind <turn> <scope> → rewind with explicit scope
scope = code | conversation | both
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run_skillis classified as a writer tool (ReadOnly() = false) because subagent skills can spawn isolated loops that call writer tools. This blocks ALL skill usage in plan mode, even for inline skills which are purely informational and have zero side effects.Fixes #3491
Solution
Add
read_skill— a read-only counterpart that only loads inline skill bodies:ReadOnly()returnstrue→ callable in plan moderun_skillinsteadname/argumentsschema asrun_skillfor easy migrationSubagentMetaTools()exclusion list so sub-agents don't inherit itChanges (7 files, +122/-5)
internal/skill/tools.goreadSkillTool+NewReadSkillTool(+80 lines)internal/skill/tools_test.gointernal/boot/boot.goread_skillin tool registryinternal/agent/task.goread_skillto meta-tool exclusion listinternal/skill/index.goread_skillin skills index headerinternal/skill/skill_test.gointernal/agent/task_test.goTesting
All pass (97s agent suite, 4 new read_skill tests).