feat(rpc): unavailable pending data only errs when we actually depend on it#3469
Merged
Conversation
…ss the request explicitly asked for it
…rr on missing pending data
t00ts
force-pushed
the
t00ts/rpc-pending-optional
branch
from
1882d21 to
46cd7f4
Compare
t00ts
changed the title
sistemd
approved these changes
Jun 10, 2026
CHr15F0x
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
PendingWatcher::get_optional(..)(sibling to the existing.get(..)) that will still surfaceInternalerrors but will tolerateUnavailableby returningNone. This allows any method that doesn't really need pending data to query it as optional and not fail.I've applied the fix to:
get_eventsget_transaction_*trace_transactionCloses #3455