Repository navigation
Conversation
Add macos-req.txt with PyQt5 dependency and update README installation instructions to use uv for Python 3.10 version management, with platform-specific requirement files.
Exposes the new goosli_v2 supports.min_island_area threshold so small overhang islands can be dropped automatically from generated supports.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 133e13b4fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| 1. Create virtual environment: `uv venv --python 3.10` | ||
| 2. Activate virtual environment: | ||
| - Windows: `venv\Scripts\activate.bat` |
There was a problem hiding this comment.
After step 1 (uv venv --python 3.10), uv creates the environment at .venv when no path is provided, so the Windows command here points to a non-existent directory. Users following the README verbatim on Windows will fail at activation (venv\Scripts\activate.bat), which blocks setup before dependency installation.
Useful? React with 👍 / 👎.
|
Recreating from master — prior branch included an unrelated macOS setup commit. |
1 participant
Summary
Pairs with epit3d/goosli_v2#215 which adds the backend threshold.
Test plan