Repository navigation
perf: opt-in omission of unused DSpark MTP residual buffer - #85
Merged
Merged
Conversation
Member
Author
|
GPU follow-up on TP2 H100 NVL, same-image flag off/on:
This establishes an actual profiled KV capacity increase, not merely an allocation estimate. No production deployment or default-flag change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Narrow allocation-only change, not upstream #55575's auxiliary-compute optimization. With
VLLM_PCAI_DSPARK_SKIP_MTP_BUFFER=1, V2 DSpark with valid configured auxiliary layers and PP1 does not allocate the target_mtp_hidden_buffer. Default, ordinary MTP, V1, PP and missing/invalid auxiliary configurations retain the existing buffer.The DSpark auxiliary consumer ignores the MTP residual. At our 4096-token, 4096-hidden, hc_mult4 bf16 geometry this omits 128 MiB/GPU. No auxiliary arithmetic, target computation or workspace/graph-lifetime changes. No production changes.
Evidence
Evaluation instructions:
docs/dspark-mtp-buffer.md. Compare the SAME image flag off/on, without packed scales or other experiment flags.