Document unlisted env vars + write down all env vars in a single file - #23
Open
Human9000-bit wants to merge 1 commit into
Open
Document unlisted env vars + write down all env vars in a single file#23Human9000-bit wants to merge 1 commit into
Human9000-bit wants to merge 1 commit into
Conversation
Only 32 of the 136 environment variables the workspace reads were documented, spread across four sections that had drifted apart. Add docs/env-vars.md covering all 158 (including CI scripts), grouped by area with defaults taken from the call sites rather than the old docs. Two things the previous docs never stated and that bite in practice: most knobs are presence-checked, so YSCV_REORDER_FUSION_OFF=0 still disables the pass; and every hot-path knob is OnceLock-cached on first read, so setting one mid-process does nothing. Three variables were documented but no longer exist in the code (YSCV_FUSED_DW_PW_STREAM_MT, YSCV_FUSED_DW_PW_STREAM_PADDED_OFF, YSCV_MPS_DEBUG), and YSCV_AARCH64_LOW_K_BLOCKED_MIN_WORK_FMAS was listed with a default of 500000 where the code uses 1048576. The claim that x86_64 enables padded DW->PW streaming by default was also wrong: it is off on every target. Keep the existing curated "most used" lists in place and repoint their canonical-reference links here; onnx-cpu-kernels.md keeps its A/B table since the tracker reproduction commands below it use those vars.
Human9000-bit
force-pushed
the
document-env-vars
branch
from
August 4, 2026 18:12
80ecaf4 to
3b96ab6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only 32 of the 136 environment variables the workspace reads were
documented, spread across four sections that had drifted apart. Add
docs/env-vars.md covering all 158 (including CI scripts), grouped by
area with defaults taken from the call sites rather than the old docs.
Two things the previous docs never stated and that bite in practice:
most knobs are presence-checked, so YSCV_REORDER_FUSION_OFF=0 still
disables the pass; and every hot-path knob is OnceLock-cached on first
read, so setting one mid-process does nothing.
Three variables were documented but no longer exist in the code
(YSCV_FUSED_DW_PW_STREAM_MT, YSCV_FUSED_DW_PW_STREAM_PADDED_OFF,
YSCV_MPS_DEBUG), and YSCV_AARCH64_LOW_K_BLOCKED_MIN_WORK_FMAS was
listed with a default of 500000 where the code uses 1048576. The claim
that x86_64 enables padded DW->PW streaming by default was also wrong:
it is off on every target.
Keep the existing curated "most used" lists in place and repoint their
canonical-reference links here; onnx-cpu-kernels.md keeps its A/B table
since the tracker reproduction commands below it use those vars.