Fix: intersect() drops Validated types when merging interface with extends#2451
Open
nickpokhilko wants to merge 1 commit into
Open
Fix: intersect() drops Validated types when merging interface with extends#2451nickpokhilko wants to merge 1 commit into
nickpokhilko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
(Validated, Validated),(Validated, _)and(_, Validated)arms tointersect()intsparser/src/parser/types/typ.rs.Why
When resolving
interface Derived extends Base, fields present in both interfaces with validators in the derived type (e.g.string & MinLen<1>) fell through all existing patterns to the catch-all(_, _) => Type::Basic(Basic::Never), silently erasing the field from the parsed schema.Root cause path:
do_interface_declintersects the derived interface body with each base type viaintersect(derived, base)Validated { typ: Basic(String), expr: MinLen∧MaxLen }and the base isBasic(String)intersect(Validated{…}, Basic(String))matched none of the existingValidation/Validatedarms (which only handleValidation— the unapplied expression type, notValidated— the already-applied wrapper)(_, _) => Type::Basic(Basic::Never)Verification
Added
tests/testdata/interface_extends_validation.txtcovering:extendswithMinLen/MaxLenvalidators on an inherited fieldextendswith optional validated fieldscargo test -p encore-tsparser test_parserpasses.