Skip to content

Conversation

@sabiwara
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Jan 19, 2026

Pull Request Test Coverage Report for Build f2b9275beea68a3e5b61ecc31ee51ec4fa59e258-PR-474

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.772%

Totals Coverage Status
Change from base Build e28c85aad15d1f0cfcb1d5e4f4abada5f37f0f11: 0.0%
Covered Lines: 1292
Relevant Lines: 1472

💛 - Coveralls

@whatyouhide
Copy link
Contributor

@sabiwara tests fail consistently on 1.15. Have you tried the suite locally?

@sabiwara
Copy link
Author

@whatyouhide sorry I only ran them on 1.19.
Will try to revert the require one for now to see if it fixes it.

@sabiwara
Copy link
Author

Hum actually even main fails on 1.15, seems unrelated to the changes 🤔

@sabiwara
Copy link
Author

@whatyouhide if I run the "for some reason works" fix from here (even on OTP24), it seems to fix it. No idea what it's about though and how it should actually be fixed.
I pushed f2b9275 in case we want to move forward with this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants