Skip to content

Internal: Update daily test with Elementor [TMZ-1028]#627

Merged
hein-obox merged 4 commits into
mainfrom
internal/TMZ-1028-fix-daily-tests
May 8, 2026
Merged

Internal: Update daily test with Elementor [TMZ-1028]#627
hein-obox merged 4 commits into
mainfrom
internal/TMZ-1028-fix-daily-tests

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 7, 2026

✨ PR Description

1. Problem & Context

Emoji characters in workflow logs were breaking CI parsing or causing display issues. Removed decorative emojis from echo statements across the daily test workflow while preserving functional logging. Also fixed a subtle bug where Elementor version output came from set-versions step instead of the actual download step, causing version mismatch in reports when fallbacks occurred.

Ticket: TMZ-1028

2. What Changed (Where)

  • .github/workflows/playwright-with-specific-elementor-version.yml: Stripped emoji prefixes (✅, ❌, 🔍, etc.) from ~80 echo statements across build-core-components, core-playwright-tests, and core-playwright-tests-tagged jobs. Changed Elementor version output to read from download-elementor step instead of set-versions.

3. How It Works

Version tracking fix: Line 50 now captures elementor-version from steps.download-elementor.outputs.effective-version instead of steps.set-versions.outputs.elementor-version. The download step sets effective-version output at lines 124, 131, 141 based on what was actually downloaded (stable, specific version, or fallback), ensuring accurate version reporting in build summaries (line 160).

Log cleanup: All emoji prefixes removed from echo statements while keeping the actual log messages intact. Status indicators now use plain text ("Elementor directory found" instead of "✅ Elementor directory found").

4. Risks

None. Changes are cosmetic logging plus a version tracking accuracy fix. The Elementor version output change improves correctness when fallbacks trigger, but doesn't alter download logic or test execution.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Playwright CI workflow to avoid emoji characters in logs (to prevent output parsing issues) and to report the effective Elementor version actually downloaded during the run.

Changes:

  • Removed emoji characters from echo statements across the workflow’s jobs.
  • Added an effective-version step output on the Elementor download step and wired job output elementor-version to it.
Comments suppressed due to low confidence (1)

.github/workflows/playwright-with-specific-elementor-version.yml:160

  • This summary row references steps.set-versions.outputs.elementor-version, but that output is no longer set (the echo was removed) and the job output was switched to steps.download-elementor.outputs.effective-version. As a result, the Elementor version shown in the summary will be empty/incorrect. Use the new download-elementor output (or the job output) when populating the Elementor Core version in the summary.
          echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
          echo "| Component       | Version                    | Source               |" >> $GITHUB_STEP_SUMMARY
          echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
          echo "| Hello Theme     | ${{ env.HELLO_THEME_VERSION }} (${{ env.HELLO_THEME_INPUT }}) | ${{ env.HELLO_THEME_SOURCE_TYPE }} |" >> $GITHUB_STEP_SUMMARY
          echo "| Elementor Core  | ${{ steps.set-versions.outputs.elementor-version }} | WordPress.org/GitHub |" >> $GITHUB_STEP_SUMMARY

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/playwright-with-specific-elementor-version.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/playwright-with-specific-elementor-version.yml:161

  • Generate build summary still references ${{ steps.set-versions.outputs.elementor-version }}, but set-versions no longer sets an elementor-version output. This will make the summary show an empty/incorrect Elementor version; it should use the new download-elementor step output instead (e.g. ${{ steps.download-elementor.outputs.effective-version }} or the job output).
          echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
          echo "| Component       | Version                    | Source               |" >> $GITHUB_STEP_SUMMARY
          echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
          echo "| Hello Theme     | ${{ env.HELLO_THEME_VERSION }} (${{ env.HELLO_THEME_INPUT }}) | ${{ env.HELLO_THEME_SOURCE_TYPE }} |" >> $GITHUB_STEP_SUMMARY
          echo "| Elementor Core  | ${{ steps.set-versions.outputs.elementor-version }} | WordPress.org/GitHub |" >> $GITHUB_STEP_SUMMARY
          echo "" >> $GITHUB_STEP_SUMMARY

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@hein-obox hein-obox merged commit 7982fda into main May 8, 2026
45 checks passed
@hein-obox hein-obox deleted the internal/TMZ-1028-fix-daily-tests branch May 8, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants