Internal: Update daily test with Elementor [TMZ-1028]#627
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Playwright CI workflow to avoid emoji characters in logs (to prevent output parsing issues) and to report the effective Elementor version actually downloaded during the run.
Changes:
- Removed emoji characters from
echostatements across the workflow’s jobs. - Added an
effective-versionstep output on the Elementor download step and wired job outputelementor-versionto it.
Comments suppressed due to low confidence (1)
.github/workflows/playwright-with-specific-elementor-version.yml:160
- This summary row references
steps.set-versions.outputs.elementor-version, but that output is no longer set (the echo was removed) and the job output was switched tosteps.download-elementor.outputs.effective-version. As a result, the Elementor version shown in the summary will be empty/incorrect. Use the newdownload-elementoroutput (or the job output) when populating the Elementor Core version in the summary.
echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
echo "| Component | Version | Source |" >> $GITHUB_STEP_SUMMARY
echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
echo "| Hello Theme | ${{ env.HELLO_THEME_VERSION }} (${{ env.HELLO_THEME_INPUT }}) | ${{ env.HELLO_THEME_SOURCE_TYPE }} |" >> $GITHUB_STEP_SUMMARY
echo "| Elementor Core | ${{ steps.set-versions.outputs.elementor-version }} | WordPress.org/GitHub |" >> $GITHUB_STEP_SUMMARY
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/playwright-with-specific-elementor-version.yml:161
Generate build summarystill references${{ steps.set-versions.outputs.elementor-version }}, butset-versionsno longer sets anelementor-versionoutput. This will make the summary show an empty/incorrect Elementor version; it should use the newdownload-elementorstep output instead (e.g.${{ steps.download-elementor.outputs.effective-version }}or the job output).
echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
echo "| Component | Version | Source |" >> $GITHUB_STEP_SUMMARY
echo "|-----------------|----------------------------|-----------------------|" >> $GITHUB_STEP_SUMMARY
echo "| Hello Theme | ${{ env.HELLO_THEME_VERSION }} (${{ env.HELLO_THEME_INPUT }}) | ${{ env.HELLO_THEME_SOURCE_TYPE }} |" >> $GITHUB_STEP_SUMMARY
echo "| Elementor Core | ${{ steps.set-versions.outputs.elementor-version }} | WordPress.org/GitHub |" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
…s' into internal/TMZ-1028-fix-daily-tests
nicoladj77
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Emoji characters in workflow logs were breaking CI parsing or causing display issues. Removed decorative emojis from echo statements across the daily test workflow while preserving functional logging. Also fixed a subtle bug where Elementor version output came from
set-versionsstep instead of the actual download step, causing version mismatch in reports when fallbacks occurred.Ticket: TMZ-1028
2. What Changed (Where)
.github/workflows/playwright-with-specific-elementor-version.yml: Stripped emoji prefixes (✅, ❌, 🔍, etc.) from ~80 echo statements across build-core-components, core-playwright-tests, and core-playwright-tests-tagged jobs. Changed Elementor version output to read fromdownload-elementorstep instead ofset-versions.3. How It Works
Version tracking fix: Line 50 now captures
elementor-versionfromsteps.download-elementor.outputs.effective-versioninstead ofsteps.set-versions.outputs.elementor-version. The download step setseffective-versionoutput at lines 124, 131, 141 based on what was actually downloaded (stable, specific version, or fallback), ensuring accurate version reporting in build summaries (line 160).Log cleanup: All emoji prefixes removed from echo statements while keeping the actual log messages intact. Status indicators now use plain text ("Elementor directory found" instead of "✅ Elementor directory found").
4. Risks
None. Changes are cosmetic logging plus a version tracking accuracy fix. The Elementor version output change improves correctness when fallbacks trigger, but doesn't alter download logic or test execution.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how