Skip to content

build: TS6 + oxc.rs#437

Merged
erickzhao merged 1 commit intomainfrom
oxc-rs
Apr 20, 2026
Merged

build: TS6 + oxc.rs#437
erickzhao merged 1 commit intomainfrom
oxc-rs

Conversation

@erickzhao
Copy link
Copy Markdown
Member

@erickzhao erickzhao commented Apr 14, 2026

This PR migrates us to oxc.rs from ESLint/Prettier. Going to do this across all Ecosystem WG-owned repos.

Migration guidelines

Formatting

  • Existing Prettier configuration ported to oxfmt to minimize diff.
  • Markdown and YAML ignored.

Linting

  • oxlint configuration intentionally kept minimal. All default plugins enabled, with import added as well.
  • TypeScript repos attempt to use typeAware mode via oxlint-tsgolint.
    • This is sometimes impossible in a straight migration due to legacy moduleResolution: node settings. This is noted whenever relevant.

Other

  • husky + lint-staged set up for pre-commit hooks.
  • package.json scripts standardized as lint and lint:fix.
  • typescript dependency upgraded to v6 for building the repos. We maintain configuration compatibility with tsgo while keeping a stable version of TypeScript.
    • Where relevant (for packages.electronjs.org repos) typedoc is upgraded to 0.28 accordingly, but this triggers some socket.dev warnings that I would like reviewers to mark as acceptable risk.

Full list of PRs

TODO:

  • electron/github-app-auth-action
  • electron/remote
  • electron/windows-installer

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 14, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxfmt@​0.44.0901008996100
Updatedtypescript@​5.5.4 ⏵ 6.0.2100 +110090 +110090
Addedoxlint@​1.59.0991009196100
Updatedtypedoc@​0.25.13 ⏵ 0.28.181001009894 -1100
Addedoxlint-tsgolint@​0.20.01001009796100

View full report

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 14, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@erickzhao erickzhao changed the title build: TS 6 + oxc.rs build: TS6 + oxc.rs Apr 14, 2026
@erickzhao erickzhao marked this pull request as ready for review April 15, 2026 00:38
@erickzhao erickzhao requested a review from a team as a code owner April 15, 2026 00:38
@MarshallOfSound
Copy link
Copy Markdown
Member

@SocketSecurity ignore npm/[email protected]

@MarshallOfSound
Copy link
Copy Markdown
Member

@SocketSecurity ignore npm/[email protected]

@erickzhao erickzhao merged commit 53b3bd3 into main Apr 20, 2026
11 checks passed
@erickzhao erickzhao deleted the oxc-rs branch April 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants