Repository navigation
Conversation
github-actions
Bot
added
agent-java
community
Contributor
|
Thanks, please add test coverage for custom values, escaping, and preservation of the default behavior. Each new configuration path should ideally test both the default 1.2.0 and a custom ecs.version. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to override the
ecs.versionwhich is present in every log event and currently is set to a fixed version of1.2.0which is pretty old.To preserve backwards compatibility I left the old method within
EcsJsonSerializeralthough it is no longer called from within the library itself.Fixes #289