Add missing page-level applies_to for ingest docs
#3238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishaangelova
commented
Sep 30, 2025
Contributor
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
b2593ff to
07769aa
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
07769aa to
11eed7d
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
11eed7d to
3ff46ce
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
3ff46ce to
b70b4ea
Compare
Contributor
Vale Linting ResultsSummary: 1 warning, 5 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| reference/fleet/mutual-tls.md | 148 | Elastic.DontUse | Don't use 'at this point'. |
💡 Suggestions (5)
| File | Line | Rule | Message |
|---|---|---|---|
| reference/fleet/agent-command-reference.md | 269 | Elastic.Acronyms | 'SHA' has no definition. |
| reference/fleet/agent-command-reference.md | 661 | Elastic.Acronyms | 'SHA' has no definition. |
| reference/fleet/grant-access-to-elasticsearch.md | 17 | Elastic.Wordiness | Consider using 'to' instead of 'in order to'. |
| reference/fleet/mutual-tls.md | 148 | Elastic.Wordiness | Consider using 'because' instead of 'Since'. |
| reference/fleet/mutual-tls.md | 191 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
8d9bc46 to
f6f33ba
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
f6f33ba to
5cca8ea
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
5cca8ea to
1ff9569
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
78b4f46 to
92f0d63
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
2 times, most recently
from
57c3bc2 to
8ad29a1
Compare
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
8ad29a1 to
796e752
Compare
alexandra5000
approved these changes
Dec 17, 2025
karenzone
reviewed
Dec 18, 2025
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left comments and suggestions inline for Configure Standalone Agents
karenzone
reviewed
Dec 19, 2025
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left comments and suggestions inline
Contributor
|
@vishaangelova, I made more than one review pass to not risk GitHub timing out and flushing my comments. Please let me know if you'd like to get together and discuss. |
vishaangelova
force-pushed
the
ingest-docs-add-page-level-applies-to
branch
from
eb80e00 to
7fb03b6
Compare
karenzone
reviewed
Dec 19, 2025
karenzone
reviewed
Dec 19, 2025
vishaangelova
commented
Dec 19, 2025
karenzone
approved these changes
Dec 19, 2025
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
@vishaangelova, we've addressed concerns and have plans in place to continue iterating with tooling updates coming soon. So for now, LGTM. 🎉
Contributor
Author
|
@bmorelli25, now that Karen has approved, do you think we can merge this? I've addressed your comments in d0dd048, 233a90f, and 796e752. Let me know if I missed something and I’ll have a look. If not, feel free to merge! |
bmorelli25
approved these changes
Dec 19, 2025
Member
bmorelli25
left a comment
bmorelli25
left a comment
There was a problem hiding this comment.
🚀 nice job! And a big thank you to all of the reviewers as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds/updates page-level
applies_toinformation for:manage-data/ingestfolderreference/apm-agents/index.md(+ adds some links)reference/fleetfolder:index.md)reference/ingestion-tools/index.md(+ adds some links)Generative AI disclosure
Cursor / gpt-5.1 model
Review assignments