Open
Conversation
github-actions
bot
added
topic: barrel
veprbl
reviewed
Apr 14, 2026
Contributor
Author
I have updated the sensor and pixel size to match what the TDR states. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Half a year ago, pixel dimensions of ETOF and BTOF sensors are reduced to unrealistic sizes to compensate for the reduction in position resolution due to lack of charge sharing algorithm: #883
Now, TOF group believes that charge sharing algorithm is mature to an acceptable state. Therefore, we will enable charge sharing in another pull request in EICrecon, and at the same time we will return pixel dimensions to their realistic size.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply