Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add the AdePT (g4adept) package into the CUDA container build by bringing in the necessary Spack package definitions via spack-packages cherry-picks.
Changes:
- Added spack-packages cherry-picks for newly introduced
g4hepemandg4adeptpackages. - Documented the new cherry-picks in the hash reference comment block.
wdconinc
commented
Apr 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
spack-environment/packages.yaml:196
+autotoolsis not used anywhere else inpackages.yaml, and Spack typically selects the build system viabuild_system=autotools(seefreetypeatspack-environment/packages.yaml:183-186). As written,+autotoolsis likely an invalid variant forgdband may break concretization; consider restoring the previous+debuginfodrequirement or switching tobuild_system=autotoolsif that was the intent.
gdb:
require:
- '@15.2:'
- +debuginfod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR installs AdePT in our cuda containers.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
Copilot suggested a commit message. This can't be turned off.