-
Notifications
You must be signed in to change notification settings - Fork 1
[DIGIT-361] Property Tax Onboarding #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amoghrman
wants to merge
3
commits into
egovernments:master
Choose a base branch
from
Infosys:DIGIT-361
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| *.json | ||
| *.md | ||
| /migrations | ||
| .env | ||
| *.yaml | ||
| *.yml | ||
| .gitignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Binaries for programs and plugins | ||
| *.exe | ||
| *.exe~ | ||
| *.dll | ||
| *.so | ||
| *.dylib | ||
|
|
||
| # Test binary, built with `go test -c` | ||
| *.test | ||
|
|
||
| # Output of the go build command | ||
| /property-tax-onboarding | ||
|
|
||
| # Go workspace file | ||
| go.work | ||
| go.sum | ||
|
|
||
| # Environment variables | ||
| .env | ||
|
|
||
| # IDE files | ||
| .vscode/ | ||
| .idea/ | ||
| *.swp | ||
| *.swo | ||
|
|
||
| # OS generated files | ||
| .DS_Store | ||
| .DS_Store? | ||
| ._* | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ehthumbs.db | ||
| Thumbs.db | ||
|
|
||
| # Logs | ||
| *.log | ||
| logs/ | ||
|
|
||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
| # Dependency directories | ||
| vendor/ | ||
| node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Build stage | ||
| FROM golang:1.25-alpine AS builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy go.mod and go.sum files | ||
| COPY go.mod go.sum ./ | ||
|
|
||
| # Download dependencies | ||
| RUN go mod download | ||
|
|
||
| # Copy the source code | ||
| COPY . . | ||
|
|
||
| # Build the application (main.go is in cmd/server/) | ||
| RUN CGO_ENABLED=0 GOOS=linux go build -o property-service ./cmd/server/main.go | ||
|
|
||
| # Final stage | ||
| FROM alpine:3.19 | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Install ca-certificates for HTTPS requests | ||
| RUN apk --no-cache add ca-certificates | ||
|
|
||
| # Copy the binary from the builder stage | ||
| COPY --from=builder /app/property-service . | ||
|
|
||
| # Set permissions | ||
| RUN chmod +x /app/property-service | ||
|
|
||
| # Expose port 8080 (default property service port) | ||
| EXPOSE 8080 | ||
|
|
||
| # Set the entry point | ||
| ENTRYPOINT ["./property-service"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding /migrations may break database initialization in containers.
Database migrations are typically needed for schema setup when deploying containerized applications. Excluding
/migrationsmeans the SQL files won't be available in the Docker image for initialization tasks.🔎 Proposed fix
If migrations are applied externally (e.g., via a separate init container or migration tool), this is acceptable. Otherwise, remove this line:
*.json *.md -/migrations .env *.yaml *.yml .gitignore📝 Committable suggestion
🤖 Prompt for AI Agents