Repository navigation
Conversation
This needs a test case, but I'm not sure how to add one Fixes eemeli#735 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
marked this pull request as draft
October 21, 2026 20:50
datho7561
marked this pull request as ready for review
October 26, 2026 13:07
Contributor
Author
|
@eemeli if you think this fix is correct, feel free to take over this PR and add tests/whatever else is needed to get it merged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #735
LLM Use
No LLMs were used in writing or working on the code, comments, or PR description.
Description
Adjust the regular expression used to identify float point numbers in scientific notation to require that they have a decimal point. This aligns with the YAML 1.1 spec, and results in
3E0being treated as a string rather than a floating point number.I've tested this in vscode-yaml, which uses the type information provided by this library to validate YAML files against a JSON schema. Before this change,
3E0was being treated as a number for type validation under YAML 1.1, and after, it's being treated as a string.