fix: authenticate private GitHub repos in containerized sandbox - #367
Merged
srathod-apphelix merged 1 commit intoAug 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the containerized sandbox (edxapp LMS/CMS) image build flow to authenticate GitHub when BuildKit fetches a private edx/edx-platform repository during Docker builds.
Changes:
- Switch the container build process to export
GITHUB_TOKENfrom a newapp_git_pat_tokenvariable for BuildKit git auth. - Read
LOCAL_GIT_PAT_TOKENfromconfiguration_secure_secret(AWS Secrets Manager) and plumb it into the provisioning scripts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| util/jenkins/app-container-provisioner.sh | Exports GITHUB_TOKEN from app_git_pat_token before BuildKit-based docker build steps that require GitHub auth. |
| util/jenkins/ansible-provision.sh | Reads LOCAL_GIT_PAT_TOKEN from Secrets Manager into app_git_pat_token for downstream container provisioning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+788
to
789
| app_git_pat_token=$(echo "$configuration_secure_json" | jq -r '.LOCAL_GIT_PAT_TOKEN // empty') | ||
|
|
ktyagiapphelix2u
approved these changes
Aug 11, 2026
srathod-apphelix
deleted the
srathod/GSRE-4332-containerized-sandbox-local-git-pat-token
branch
August 11, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes containerized sandbox edxapp (LMS/CMS) Docker image build failures when
cloning private
edx/edx-platformfrom GitHub.Jira - GSRE-4332
Purpose
Containerized sandboxes (
edxapp_container_enabled=true) no longer build from anin-repo Dockerfile. They use:
public-dockerfiles/dockerfiles/edx-platform.Dockerfilefor the base imageinternal-dockerfiles/edx-platform-privatefor the private overlayThe public Dockerfile fetches edx-platform inside the image with:
ADD https://github.com/${EDX_PLATFORM_REPO}.git#${EDX_PLATFORM_VERSION}For sandbox,
EDX_PLATFORM_REPO=edx/edx-platform(private). BuildKit requiresa GitHub PAT passed as
--secret id=GIT_AUTH_TOKEN,env=GITHUB_TOKEN, matchingthe production GoCD edxapp build pattern.
Changes
ansible-provision.shLOCAL_GIT_PAT_TOKENfromconfiguration_secure_secret(AWS Secrets Manager)app_git_pat_tokenapp-container-provisioner.shGITHUB_TOKENfromapp_git_pat_tokenduring edx-platform image build--secret id=GIT_AUTH_TOKEN,env=GITHUB_TOKENto:edx-platform.Dockerfilebase buildedx-platform-privateLMS/CMS overlay build