build: empty private requirements - #366
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the default, hard-coded EDXAPP_PRIVATE_REQUIREMENTS list from the edxapp role defaults to avoid implying these dependencies are broadly used, leaving an empty default intended for sandbox-specific configuration.
Changes:
- Replaces the previously populated
EDXAPP_PRIVATE_REQUIREMENTSdefaults with an empty list. - Updates the surrounding comment to remove the “Edge” reference and narrow the stated scope to EC2 sandboxes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jansenk
force-pushed
the
jkantor/remove-private-requirements
branch
from
August 10, 2026 16:01
284d96e to
d88f8c9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
playbooks/roles/edxapp/defaults/main.yml:529
- The comment says these defaults are used for sandboxes in EC2, but the list is now intentionally empty per the PR description. Clarifying where sandbox private requirements are now defined would avoid confusion for future maintainers.
# Defaults for EDXAPP_PRIVATE_REQUIREMENTS are used for sandboxes in EC2.
EDXAPP_PRIVATE_REQUIREMENTS: []
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
playbooks/roles/edxapp/defaults/main.yml:529
EDXAPP_PRIVATE_REQUIREMENTSentries are consumed as objects with.nameand optional.extra_args(see roles/edxapp/tasks/deploy.yml). With the defaults now an empty list, it’s easy for future overrides to accidentally supply a list of strings (which will break the install task). Consider documenting the expected item shape here, and note that the list is only used whenEDXAPP_INSTALL_PRIVATE_REQUIREMENTSis enabled.
# Defaults for EDXAPP_PRIVATE_REQUIREMENTS are used for sandboxes in EC2.
EDXAPP_PRIVATE_REQUIREMENTS: []
timmc-edx
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting should only be currently read by sandboxes, so these were moved over to sandbox_internal to reduce potential confusion re: where they are actually used.
see https://github.com/edx/sandbox-internal/pull/391