feat(brief,builder): cite the peer callsite for composition slices#253
Merged
Conversation
) The builder made locally-reasonable, globally-wrong calls where the correct pattern was in the same file: cmd_custodian hardcoded open_local_meta_redb with no resolve_backend arm while cmd_put/cmd_get two functions away already resolved the backend (wyrd #366 Iter-3); a positional DServerId instead of the registered failure-domain; an inverted stream-don't-buffer invariant (#364). "Read brief.md only" gave Do no cue to consult the peer callsite. For composition slices, Plan now names the peer callsite in Citations expected, and Do MAY open that one cited callsite — a narrow, deliberate exception to the narrow-input wall. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #248.
Problem
The builder made locally-reasonable, globally-wrong calls where the correct pattern was in the same file:
cmd_custodianhardcodedopen_local_meta_redbwith noresolve_backend/TiKV arm, whilecmd_put/cmd_gettwo functions away already resolve the backend (cli.rs:865) — so on a real TiKV cluster the custodian opens an empty local redb (wyrd #366 Iter-3).DServerIdinstead of the registered failure-domain (#366 Iter-3)."Read
brief.mdonly" gives Do no cue to consult the peer callsite that already solves the composition, even though the builder can read the target repo.Change
Confirmed design: relax the narrow-input wall for brief-cited callsites (rather than require Plan to inline peer code).
templates/brief.md.tpl—Citations expectedMAY name a peer callsite Do should mirror (path:line+ how).agents/builder.md.jinja— a narrow, explicit exception: Do MAY open the one callsite the brief cites inCitations expected, solely to mirror the pattern; the wall is otherwise absolute.agents/planner.md.jinja— for composition slices, Plan names the peer callsite inCitations expected.Single-source:
.claude/agents/*{% include %}the bodies.Verification
cd template && make check— 478 driver unit tests pass.builder.md.jinja/planner.md.jinjaparse cleanly (jinja2).🤖 Generated with Claude Code