Sync addons-source@maintenance/gramps61 with upstream (2026-06-30)#59
Sync addons-source@maintenance/gramps61 with upstream (2026-06-30)#59eduralph wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2000d6b19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r'(?P<nad>SE/\w+/\d+/[^,]+)\s*' | ||
| r'\((?P<years>\d{4}(?:-\d{4})?)\),\s*' | ||
| r'bildid[^_]*_(?P<bildid>\d+)' | ||
| r'(?P<nad>[^\(]+)*' |
There was a problem hiding this comment.
When the user pastes a partial Riksarkivet-like string with two comma-separated fields but no following ( year section, (?P<nad>[^\(]+)* can repartition the same NAD text exponentially while trying to satisfy the next group, so the GTK click handler can freeze on short invalid input; in addition, the outer * lets nad be None before the later .strip(). Make the NAD portion required without the outer repetition, or fail before dereferencing it.
Useful? React with 👍 / 👎.
eduralph
force-pushed
the
sync/upstream-maintenance-gramps61-auto
branch
7 times, most recently
from
f3e6a77 to
92887d6
Compare
eduralph
force-pushed
the
sync/upstream-maintenance-gramps61-auto
branch
from
92887d6 to
41ec6fc
Compare
1 participant
Automated nightly sync from
gramps-project/addons-source@maintenance/gramps61. Generated by .github/workflows/upstream-sync.yml on the testbed.