v4 - #153
Merged
Merged
Conversation
Im so tired of this
Teleported source content renders inside the paired screen's portal host, so when the destination ScrollView moved after capture the dismiss path landed offset from the true source position, and iOS rubber-band offsets overcompensated the correction. The coordinate basis is now fixed at capture and the only live input is the clamped scroll offset, so nothing can jump mid-flight: - clamp scroll deltas to the layout range everywhere (new shared clampScrollAxisOffset / getClampedScrollAxisDelta helpers), so rubber-band overshoot never becomes a coordinate-space delta - portal hosts compensate for any cross-screen source, expressing the source rect in the host's current scrolled frame; hosts that do not capture scroll store no snapshot and resolve to a 0 delta - the bounds path shifts the teleported source (and screen-fixed target overrides) by the destination's clamped scroll travel since capture, read from the hydrated transition states' live scroll - host measurements taken mid rubber-band are normalized to their at-rest frame before storing - the link source side records its portal host so the correction is scoped to paired-screen teleport links; refresh paths preserve it Classic two-component links never set a portal host and skip all of this; zero-delta paths return identical objects. An equivalence test pins that a teleported link with a scrolled destination matches a classic link whose source is pre-shifted by the clamped delta. Also includes in-progress teleport e2e screens and zoom build adjustments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Consume Standard Navigator state, helpers, and descriptors directly. BREAKING CHANGE: Remove the unused independent prop and BlankStackFactoryOptions export.
Retire the product-specific shared presets and their obsolete E2E flow in favor of the Bounds API. BREAKING CHANGE: Remove SharedIGImage, SharedAppleMusic, and SharedXImage from Presets.
✅ Deploy Preview for rnst-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
Author
|
ok thanks sol, I can't do anymore doc work ffs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FINALLY FUCK