.github: make the post-release action kind-aware - #2596
Merged
Conversation
sespiros
added
no changelog
Three separate boolean inputs all wired to the same `kind == 'minor'` expression at the call site meant a fourth minor-only step would have been easy to add and forget. Take `kind` once and decide inside the action instead. No behaviour change: release_promote is always a minor and keeps relying on the default. Signed-off-by: Spyros Seimenis <sse@edgeless.systems>
Skipping the check entirely on a patch left that path with no guard against a wrong checkout_main_ref, which is the failure it exists to catch. main can't carry the patch version, but it is always ahead of it, so assert that ordering instead. sort -V rather than a string compare, so 1.23.10 and 1.30.0 don't misorder. Signed-off-by: Spyros Seimenis <sse@edgeless.systems>
sespiros
force-pushed
the
sse/release-kind-input
branch
from
August 20, 2026 18:17
466b571 to
4deb1eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2594.
That PR added a third boolean to
prepare_post_release_pr, alongsidecreate_docs_releaseandbump_version, all three wired to the sameinputs.kind == 'minor'at the call site.The action was asking its caller three questions that have only ever had one answer between them, so it takes
kindonce and decides internally.Across roughly 30 post-release PRs since 1.5.2 those booleans have only ever been all-on or all-off (the 4-commit and 2-commit PRs), never mixed.
No behaviour change for minors, and
release_promote.ymlstill relies on the default.The second commit restores the guard the hot-fix had to drop.
Skipping the version check on a patch left
checkout_main_refunvalidated on that path, which is the mistake the check exists to catch.Main can never carry a patch version but is always ahead of one, so a patch asserts that ordering instead of an exact match.
By construction this is weaker than the minor check: it catches a ref that is behind the release, not one that is ahead and still wrong.
Should land after #2594.
Main-only, no backport needed.