Support more opcodes in InterpreterEmulator to inline DirectMethodHandleAccessor.isStatic - #24676
Open
matthewhall2 wants to merge 2 commits into
Open
matthewhall2 wants to merge 2 commits into
matthewhall2 wants to merge 2 commits into
Conversation
ifacmpeq and ifacmpne are both supported in maintainStackForIf, so add them to maintainStack Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
putfield should pop 2 bytes as per the jvm spec. This was causes issues with operand stacks having different sizes Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
Contributor
Author
|
@nbhuiyan this gives an additional ~18% improvement in at least instanceMethodConst and staticMethodConsts (both baseline benchmarks and with these changes run with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
ifacmpeq,ifacmpne,bipush,sipushtoInterpreterEmulator.cpp, allowingDirectMethodHandleAccessor.isStatic()to be folded to its result.builds on changes in #24504. These won't take effect until that PR is merged, since it relies on the
ifacmpeqandifacmpnesupport added there inInterpreterEmulator::maintainStackForIf()