Skip to content

[#14] Add .NET 10 support - #19

Merged
dkroenke merged 2 commits into
eclipse-iceoryx:mainfrom
patdhlk:csharp-iox2-14-dotnet10-support
Apr 17, 2026
Merged

dkroenke merged 2 commits into
eclipse-iceoryx:mainfrom
patdhlk:csharp-iox2-14-dotnet10-support

Conversation

@patdhlk

@patdhlk patdhlk commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Notes for Reviewer

This is a straightforward version bump adding net10.0 as a target framework across all projects, tests, examples, and CI. No code logic changes — only .csproj target framework additions and CI SDK setup.

The test project and Event example were also upgraded from single-target (net8.0) to multi-target (net8.0;net9.0;net10.0) for consistency with the rest of the repo.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (csharp-iox2-123-short-description)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add feature description)
  • Tests have been added/updated for new functionality
  • XML documentation comments added to public APIs
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented with XML comments
  • PR title describes the changes
  • Code follows C# conventions (PascalCase for public APIs)
    • dotnet format has been exectued before submitting

References

Closes #14

Add net10.0 target framework to all libraries, tests, and examples.
Update CI workflow to install .NET 10.0.x SDK. Also make tests and
Event example multi-target (net8.0;net9.0;net10.0) for consistency.
@dkroenke
dkroenke self-requested a review April 15, 2026 16:33

@dkroenke dkroenke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patdhlk
Looks good, thanks for the update!
I noticed warnings when building the bindings:

iceoryx2-csharp/src/Iceoryx2/Iceoryx2.csproj : warning NU1510: PackageReference System.Memory will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.

I tested it by removing the reference locally and the warning did not come up but maybe it is still needed?

Additionally an entry in the features section of the changelog is needed.

Remove unnecessary System.Memory NuGet package reference that
produces NU1510 warning (Span<T> types are in-box since netcoreapp2.1).
Add changelog entry for .NET 10 support feature.
@patdhlk
patdhlk requested a review from dkroenke April 17, 2026 09:42

@dkroenke dkroenke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@dkroenke
dkroenke merged commit 8dde348 into eclipse-iceoryx:main Apr 17, 2026
6 checks passed
@patdhlk
patdhlk deleted the csharp-iox2-14-dotnet10-support branch May 27, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET 10 Support

2 participants