Skip to content

[#17] Add Eclipse Dash license check for C# bindings - #18

Merged
dkroenke merged 6 commits into
eclipse-iceoryx:mainfrom
patdhlk:csharp-iox2-license-check
Apr 9, 2026
Merged

dkroenke merged 6 commits into
eclipse-iceoryx:mainfrom
patdhlk:csharp-iox2-license-check

Conversation

@patdhlk

@patdhlk patdhlk commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewer

Adds Eclipse Dash License Tool check for all third-party NuGet dependencies in the C# bindings.
Microsoft/System/NETStandard/NuGet/runtime packages are filtered out per the standard dash-licenses .NET convention.

Dependencies are checked per-project (libraries, tests, and examples independently).

The DEPENDENCIES file is generated by scripts/check-licenses.sh which:

  1. Lists transitive NuGet dependencies per-project via dotnet list package --include-transitive
  2. Filters out Microsoft/System/NETStandard/NuGet/runtime packages
  3. Converts remaining packages to ClearlyDefined format
  4. Pipes to the Eclipse Dash License Tool

Results: 6 approved, 6 restricted (xunit packages — all Apache-2.0, need iplab review).

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (csharp-iox2-123-short-description)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add feature description)
  • Tests have been added/updated for new functionality
  • XML documentation comments added to public APIs
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented with XML comments
  • PR title describes the changes
  • Code follows C# conventions (PascalCase for public APIs)
    • dotnet format has been exectued before submitting

References

Closes #17

…ncies

Run Eclipse Dash License Tool per-project on all third-party NuGet
dependencies (Microsoft/System/NETStandard/runtime filtered out).
Add check-licenses.sh script and DEPENDENCIES file.
@dkroenke
dkroenke self-requested a review February 24, 2026 17:15
Comment thread CHANGELOG.md Resolved
Comment thread DEPENDENCIES Resolved
Comment thread DEPENDENCIES Resolved
Comment thread DEPENDENCIES Resolved
patdhlk added 4 commits March 14, 2026 11:25
- Link ticket eclipse-iceoryx#17 in CHANGELOG.md entry
- Reference DEPENDENCIES file from NOTICE.md third-party content section
- Update test dependencies to latest versions (xunit 2.9.3,
  xunit.runner.visualstudio 2.8.2, Microsoft.NET.Test.Sdk 18.3.0)
- Regenerate DEPENDENCIES via Eclipse Dash Tool; all 12 deps now approved
The macos-latest runner was updated to a newer macOS version where
iceoryx2-pal-posix struct size assertions (sockaddr, ifaliasreq) fail.
Pin to macos-14 until the iceoryx2 submodule supports the newer macOS.
Update iceoryx2 submodule from v0.8.0 to v0.8.1 which fixes the macOS
build failure caused by struct size mismatches in iceoryx2-pal-posix.
Revert macOS CI runner back to macos-latest since the root cause is
resolved in the submodule.
The brew-installed LLVM (22.1.0) causes bindgen to generate incorrect
struct sizes for sockaddr and ifaliasreq on the updated macOS runner.
The upstream iceoryx2 CI does not install brew LLVM on macOS — the
system clang/libclang is sufficient for building the FFI library.
@patdhlk
patdhlk requested a review from dkroenke March 14, 2026 10:44

@dkroenke dkroenke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patdhlk Sorry for the delay on reviewing this PR, there is only a small nitpick to solve and we are good to go.

Comment thread scripts/check-licenses.sh Resolved
@patdhlk
patdhlk requested a review from dkroenke April 9, 2026 09:38
@dkroenke
dkroenke merged commit 9356c92 into eclipse-iceoryx:main Apr 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Eclipse Dash license check for C# bindings NuGet dependencies

2 participants