Improve oauth2#3014
Open
flobz wants to merge 6 commits intoeclipse-hawkbit:masterfrom
Open
Conversation
flobz
force-pushed
the
fix/oauth2
branch
3 times, most recently
from
31fa6ba to
ffcebf4
Compare
flobz
force-pushed
the
fix/oauth2
branch
2 times, most recently
from
ff319fd to
6117845
Compare
avgustinmm
requested changes
Apr 24, 2026
| public GroupedOpenApi mgmtApi( | ||
| @Value("${hawkbit.server.openapi.mgmt.tenant-endpoint.enabled:false}") final boolean tenantEndpointEnabled, | ||
| @Value("${hawkbit.server.security.oauth2.resourceserver.enabled:false}") final boolean oauth2Enabled, | ||
| @Value("${hawkbit.server.security.allow-http-basic-on-o-auth-enabled:false}") final boolean allowBasicAuthWithOauth, |
Contributor
There was a problem hiding this comment.
I see here you are using the configuration for the hawkbit resource server.
Wouldn't be better to just get HawkbitSecurityProperties directly and check directly?
This way you will be safe against properties changes in the future
Contributor
There was a problem hiding this comment.
here you don't have both basic + oauth (as this is supported by hawkbit)?
Contributor
There was a problem hiding this comment.
My idea was to have parameters:
@Autowired(required = false) @Qualifier("hawkbitOAuth2ResourceServerCustomizer") final Customizer<OAuth2ResourceServerConfigurer<HttpSecurity>> oauth2ResourceServerCustomizer,
final HawkbitSecurityProperties securityPropertiesand to have:
if (oauth2ResourceServerCustomizer != null) {
// add oauth
}
if (oauth2ResourceServerCustomizer == null || securityProperties.isAllowHttpBasicOnOAuthEnabled()) {
// add basic
}Alike MgmtSecurityConfiguration#filterChainREST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the following imrpovement: