Add CPP warning overrides to fix Ubuntu 13.04+#48
Closed
declension wants to merge 1 commit intoechonest:masterfrom
declension:fix-compile-warnings-on-ubuntu
Closed
Add CPP warning overrides to fix Ubuntu 13.04+#48declension wants to merge 1 commit intoechonest:masterfrom declension:fix-compile-warnings-on-ubuntu
declension wants to merge 1 commit intoechonest:masterfrom
declension:fix-compile-warnings-on-ubuntu
Conversation
Obviously, the root cause should be addressed but it's a dependency. Looks like Ubuntu 13.04 turned this on by default: https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security `setup.py` now builds fine for me. Fixes #45.
Author
|
Hmm this actually is pretty much a duplicate of #40, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously, the root cause should be addressed but it's a dependency.
Looks like Ubuntu 13.04 turned this on by default:
https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security
setup.pynow builds fine for me.Fixes #45.