Fix jackknife_se_multi for iterations with truncated matrix length#115
Open
david-loeb wants to merge 1 commit intoebenmichael:masterfrom
Open
Fix jackknife_se_multi for iterations with truncated matrix length#115david-loeb wants to merge 1 commit intoebenmichael:masterfrom
david-loeb wants to merge 1 commit intoebenmichael:masterfrom
Conversation
…ted after dropping a unit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix for a bug I encountered when attempting to use jackknife standard errors with a
multisynthobject.Issue: When an earliest-treated unit is dropped in a jackknife iteration, the maximum number of post-treatment periods decreases. This can reduce the number of event-relative time periods for which
predict()estimates effects, producing an output matrix with fewer rows than the primary result matrix. Withinjackknife_se_multi(),vapply()throws an error because the output matrix dimensions for these iterations do not match the specification.Fix: I added a block that pads the iteration result matrix if it has fewer rows than the primary result matrix.
Thank you for your work on this great package!