Skip to content

New corelib support#290

Closed
rozyczko wants to merge 11 commits intodevelopfrom
new_corelib
Closed

New corelib support#290
rozyczko wants to merge 11 commits intodevelopfrom
new_corelib

Conversation

@rozyczko
Copy link
Copy Markdown
Member

Migrated EasyReflectometryLib from the old corelib architecture (ObjBase, CollectionBase) to the new architecture (ModelBase, ModelCollection, CalculatorFactoryBase).

Base class replacement

Calculator ownership migration

Interface removal

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko added [scope] significant Breaking or major changes (MAJOR.minor.patch) [priority] high Should be prioritized soon labels Dec 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 87.85872% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.72%. Comparing base (7c7786b) to head (cf82a0e).

Files with missing lines Patch % Lines
src/easyreflectometry/calculators/factory.py 78.04% 10 Missing and 8 partials ⚠️
src/easyreflectometry/sample/base_core.py 85.71% 9 Missing and 8 partials ⚠️
src/easyreflectometry/model/model.py 92.79% 1 Missing and 7 partials ⚠️
...eflectometry/sample/collections/base_collection.py 83.33% 3 Missing and 3 partials ⚠️
...c/easyreflectometry/calculators/calculator_base.py 94.73% 1 Missing and 3 partials ⚠️
...flectometry/sample/collections/layer_collection.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #290      +/-   ##
===========================================
- Coverage    88.07%   87.72%   -0.35%     
===========================================
  Files           45       45              
  Lines         2458     2828     +370     
  Branches       285      377      +92     
===========================================
+ Hits          2165     2481     +316     
- Misses         236      258      +22     
- Partials        57       89      +32     
Flag Coverage Δ
unittests 87.72% <87.85%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...easyreflectometry/calculators/refl1d/calculator.py 100.00% <100.00%> (ø)
.../easyreflectometry/calculators/refnx/calculator.py 100.00% <100.00%> (ø)
src/easyreflectometry/project.py 77.77% <100.00%> (+0.11%) ⬆️
...yreflectometry/sample/assemblies/gradient_layer.py 96.72% <100.00%> (+0.05%) ⬆️
...eflectometry/sample/assemblies/surfactant_layer.py 83.90% <100.00%> (+0.18%) ⬆️
src/easyreflectometry/sample/collections/sample.py 94.44% <100.00%> (+3.70%) ⬆️
.../sample/elements/layers/layer_area_per_molecule.py 94.28% <100.00%> (ø)
...etry/sample/elements/materials/material_density.py 100.00% <100.00%> (ø)
...try/sample/elements/materials/material_solvated.py 98.30% <100.00%> (-0.11%) ⬇️
...flectometry/sample/collections/layer_collection.py 90.90% <50.00%> (-9.10%) ⬇️
... and 5 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko rozyczko marked this pull request as draft February 15, 2026 16:37
@rozyczko rozyczko closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] high Should be prioritized soon [scope] significant Breaking or major changes (MAJOR.minor.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant