fix(results): guard participationclass against zero participants (#2709)#2727
Closed
SAY-5 wants to merge 1 commit into
Closed
fix(results): guard participationclass against zero participants (#2709)#2727SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…aluation#2709) participationclass divided number_of_voters by number_of_participants without a guard, so evaluations with zero participants raised ZeroDivisionError when the results template tried to render the participants badge. Return 0 (the empty-bucket class) up front when number_of_participants is 0; this matches the safe pattern already used in exporters.py for the same ratio.
Member
|
Someone else is already working on this in #2713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2709.
participationclassdividednumber_of_votersbynumber_of_participantswithout a guard, so loading the results page for an evaluation with zero participants raisedZeroDivisionError. Returning 0 (the empty-bucket badge class) whennumber_of_participantsis 0 mirrors the safe pattern already used inresults/exporters.py:241for the same ratio.Added
TestParticipationClassFiltercovering the zero-participant case and the existing rounding behavior.