Card Header child alignment fixed#2719
Open
Jakobus400 wants to merge 2 commits into
Open
Conversation
richardebeling
approved these changes
May 4, 2026
| <a id="collapseOverviewCardButton" class="collapse-toggle collapsed" data-bs-toggle="collapse" href="#overviewCard" aria-expanded="false" aria-controls="overviewCard">{% translate 'Overview' %}</a> | ||
| {% if request.user.is_manager %} | ||
| <div class="ms-auto"> | ||
| <div class=""> |
Member
There was a problem hiding this comment.
If we have no classes left, let's just remove the full class="" as well -- does the <div> have some purpose anymore now, or could we also remove it completely?
janno42
requested changes
Jun 1, 2026
janno42
left a comment
janno42
left a comment
Member
There was a problem hiding this comment.
Ideally, the right-aligned content would stay right-aligned (in a new line when it doesn't fit in one line with the other content), and the padding between the elements would stay as it is now.
| @@ -162,14 +162,14 @@ <h3 class="m-0 me-1">{{ semester.name }}</h3> | |||
| <div class="card-header d-flex"> | |||
Member
There was a problem hiding this comment.
The card below this one also needs fixing.
Member
There was a problem hiding this comment.
And there is another card on the student index page (for archived semesters).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2670