Skip to content

fix: ingress headers and container name template - #1144

Merged
m8vago merged 2 commits into
developfrom
fix/ingress-and-container-name-template
Aug 31, 2026
Merged

m8vago merged 2 commits into
developfrom
fix/ingress-and-container-name-template

Conversation

@m8vago

@m8vago m8vago commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
  • deep copy merged container configs, to preserve original template values
  • ingress headers now does not overwrite the configmap

@m8vago
m8vago requested a review from a team as a code owner August 28, 2026 15:01
@github-actions github-actions Bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript pr:fix labels Aug 28, 2026
Comment thread golang/pkg/crane/k8s/configmap.go Outdated
@m8vago
m8vago force-pushed the fix/ingress-and-container-name-template branch from 0a4aadd to 1bfa63b Compare August 31, 2026 12:44
@m8vago
m8vago force-pushed the fix/ingress-and-container-name-template branch from 1bfa63b to 4b55adb Compare August 31, 2026 12:46

@nandor-magyar nandor-magyar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m8vago
m8vago merged commit 447aca2 into develop Aug 31, 2026
22 checks passed
@m8vago
m8vago deleted the fix/ingress-and-container-name-template branch August 31, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:golang lang:typescript pr:fix source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants