Repository navigation
fix(mcp): pass MiMo Code sampling and alwaysDirectTools through on generate - #3722
Merged
Merged
Conversation
…nerate MiMo Code's local and remote MCP server schemas add `sampling` (released since v0.1.10) and `alwaysDirectTools` (on main) on top of OpenCode's keys. Import already kept both in the canonical server, but generate went through the OpenCode converter's fixed passthrough list and dropped them silently. OpencodeMcp now has an `extraPassthroughServerFields` hook that MimocodeMcp overrides; the keys are copied verbatim onto transport entries only, never onto bare toggles, and OpenCode targets keep writing neither. MiMo Code rejects unknown keys only at the top level of the config, so releases without `alwaysDirectTools` ignore it. Also repoint the MiMo Code @see links from packages/opencode to packages/cli, where upstream moved the package. Closes #3701 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0179ZomNiDQHCzgoxeRVmfth
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiMo Code's MCP server schema has two per-server keys OpenCode does not have, and
rulesync generate --targets mimocodedropped both without a warning even though import kept them. This passes them through.sampling(deny|ask|allow): released since v0.1.10, present in v0.1.16.alwaysDirectTools(string[]): onmainonly (#2734). Released versions ignore it:config.tsapplies.strict()only to the top-level config, and the nested server objects are non-strict.Changes
OpencodeMcpgets aprotected static extraPassthroughServerFieldshook (empty for OpenCode). After conversion, each listed key a canonical server carries is copied verbatim onto that server's local/remote entry. Bare toggle entries are left alone.MimocodeMcpoverrides the hook with["sampling", "alwaysDirectTools"]. The keys stay in the sharedmcpServersentry, where import already puts them and other targets ignore them.@seelinks now point topackages/cliinstead ofpackages/opencode, which returns 404 since upstream feat(deepagents): migrate hooks to the Hooks v2 document format #2591.docs/reference/file-formats.md.Tests
mimocode-mcp.test.tscases: both keys reach local and remote entries but not a toggle; an import → generate round trip keeps them;opencode/opencodev1write neither.pnpm cicheckpasses (605 files, 16382 tests).Not included: the optional MiMo Desktop note from the issue, since upstream #2737 is unreleased.
Closes #3701
🤖 Generated with Claude Code
https://claude.ai/code/session_0179ZomNiDQHCzgoxeRVmfth