Repository navigation
Carry start-time memos and search attributes through redrive (#980) - #1162
Merged
4 commits merged intoNov 12, 2026
Merged
4 commits merged into
4 commits merged into
Conversation
Native refused to redrive any failed run with a memo or search attribute (unsupported_visibility_metadata) or with either in its WorkflowStarted (unsupported_source_metadata), while Core accepts start-time and inherited values (workflow#985). The successor now keeps each source memo and search attribute row as it is, upsert sequence and inheritance included, as Core's copyForRedrive does, and its WorkflowStarted keeps the source's memo and search attributes. A row workflow code upserted still refuses; such a run's MemoUpserted/SearchAttributesUpserted history also refuses as unsupported_history until native reuses upsert steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rmcdaniel
enabled auto-merge
November 12, 2026 03:48
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
github-merge-queue
Bot
removed this pull request from the merge queue due to it being already merged
Nov 12, 2026
6e1d102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #980, first slice (start-visibility carryover, Core workflow#985).
Native refused to redrive any failed run that had a memo or search attribute (
unsupported_visibility_metadata), or either in itsWorkflowStarted(unsupported_source_metadata). Core redrives start-time and inherited values.Change (
rust/src/runtime/redrive.rs)inherited_from_parent, as Core'scopyForRedrivedoes. This uses new per-dialectMEMO_REDRIVE_COPY/SEARCH_ATTRIBUTE_REDRIVE_COPY. ItsWorkflowStartedalready copies the source's payload, so it keeps the memo and search attributes there too.upserted_at_sequence > 0and not inherited) still refuse withunsupported_visibility_metadata. Such a run'sMemoUpserted/SearchAttributesUpsertedhistory also refuses asunsupported_historyuntil native reuses upsert steps (a later Match Core's failed-run redrive: visibility carryover, eligibility in describe, reused markers and timers #980 slice).parent_workflow_run_idin the start still refuses asunsupported_source_metadata.Not in this slice: describe's
can_redrive/redrive_blocked_reason(Core workflow#990). That changes a describe response the parity corpus pins to published PHP, so it comes next with reviewed native expectations. Reused markers, timers, signals, updates and upserts follow Core's later slices.Tests: new
redrive_carries_start_time_memo_and_search_attributes. It covers a failed run started with a memo and a registered keyword attribute that redrives; the successor's describe,WorkflowStartedand visibility list carry both. A run whose code upserted a memo is refused before anything is written. It passes on SQLite, PostgreSQL 16 and MySQL 8.4, along with the existing redrive and replay-clock redrive tests.🤖 Generated with Claude Code